feat(content): add recipe and tokens#31095
Draft
thetaPC wants to merge 13 commits intoionic-modularfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Apr 30, 2026
| flex-shrink: 2; | ||
| overscroll-behavior-y: contain; | ||
| overflow-y: auto; | ||
| -webkit-overflow-scrolling: touch; |
Contributor
Author
There was a problem hiding this comment.
-webkit-overflow-scrolling has become obsolete since iOS 13.
thetaPC
commented
Apr 30, 2026
| contain: size style; | ||
| } | ||
|
|
||
| :host(.ion-color) .inner-scroll { |
Contributor
Author
There was a problem hiding this comment.
There seems to be a lot deleted, but they were just moved around in the file.
thetaPC
commented
Apr 30, 2026
| @Method() | ||
| async getBackgroundElement(): Promise<HTMLElement> { | ||
| if (!this.backgroundContentEl) { | ||
| await new Promise((resolve) => componentOnReady(this.el, resolve)); |
Contributor
Author
There was a problem hiding this comment.
Created a util for this since a lot of components are using the same code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-contentdoes not fragment styles based on themes. All 3 themes share one style. However, it's not configured to the Modular Ionic.What is the new behavior?
content-interface.tstocontent.interfaces.tsand addedIonContentRecipetype.--offset-top/--offset-bottomto--internal-offset-top/--internal-offset-bottomto clearly separate them from the public CSS API..transition-effectand.transition-shadowwith theposition-horizontalmixin.-webkit-overflow-scrolling: touchfrom styles as this property has been a no-op since iOS 13.transitionShadow(present iniosmode, absent inmdmode) and thegetScrollElement()/getBackgroundElement()element ref methods.new Promise((resolve) => componentOnReady(...))patterns with a sharedwaitForComponenthelper, reducing boilerplate and improving type safety.Does this introduce a breaking change?
This PR introduces breaking changes to how
ion-contentis styled.Migration Path:
--background,--color, and--padding-*have been removed. Use the new token structure instead:If per-component customization is needed, the CSS variables can be used directly.
ion-content.md,ion-content.ios.Other information
Previews: